Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Fix WINDOW_EVENT_FOCUS_IN not delivered in some cases #91361

Merged
merged 1 commit into from
May 7, 2024
Merged

Windows: Fix WINDOW_EVENT_FOCUS_IN not delivered in some cases #91361

merged 1 commit into from
May 7, 2024

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Apr 30, 2024 •
edited
Loading

Fixes #90569.

UPDATE: This also fixes #90473 on Windows as well.

@RandomShaper RandomShaper added this to the 4.3 milestone Apr 30, 2024
@AThousandShips

This comment was marked as outdated.

Sign in to view
@akien-mga akien-mga added the bug label Apr 30, 2024
@RandomShaper RandomShaper requested a review from a team as a code owner April 30, 2024 13:06
@RandomShaper
Copy link
Member Author

I wonder how that can happen. 🤔 Well, fixed.

@RandomShaper RandomShaper force-pushed the fix_no_focusin branch 2 times, most recently from fbdba96 to cc2d710 Compare May 1, 2024 10:03
@RandomShaper RandomShaper mentioned this pull request May 1, 2024
Merged
@akien-mga akien-mga requested a review from bruvzg May 2, 2024 08:49
@RandomShaper RandomShaper force-pushed the fix_no_focusin branch 2 times, most recently from 5072e67 to d6030e0 Compare May 3, 2024 11:41
akien-mga
akien-mga reviewed May 7, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#91112 was approved, so approving this one to merge first.

@akien-mga akien-mga merged commit 2885620 into godotengine:master May 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_no_focusin branch May 7, 2024 12:08
@akien-mga akien-mga mentioned this pull request May 16, 2024
Closed
@matheusmdx matheusmdx mentioned this pull request May 21, 2024
Closed
@matheusmdx matheusmdx mentioned this pull request Jun 5, 2024
Closed
This was referenced Jun 14, 2024
Closed
Closed
@AeioMuch AeioMuch mentioned this pull request Aug 16, 2024
Closed
@Hilderin Hilderin mentioned this pull request Aug 16, 2024
Merged
@matheusmdx matheusmdx mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@bruvzg bruvzg Awaiting requested review from bruvzg

Assignees
No one assigned
Labels
bug platform:windows regression topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Caret invisible in EditorFileDialog Renaming a file sometimes shows an error popup
3 participants
@RandomShaper @AThousandShips @akien-mga